Closed conker84 closed 1 year ago
@jsleight @lucagiovagnoli @88manpreet hi everybody, can someone review this?
@jsleight @88manpreet ping
@jsleight @88manpreet I updated the PR
We have the exact same issue, and made a similar fix locally. I'm not a reviewer, but I can attest that this is an issue with the latest AWS library dependencies.
The problem is that the manifest path must be in s3a, s3n,... format, whereas the path inside the manifest must be in s3:// format.
@jsleight please lemme know if you want to fix this
@jsleight please lemme know if you want to fix this
Yeah fixing this issue definitely seems correct. I think I left a comment on the one main discussion thread for a slight tweak before we merge it.
I just merged #110 which is a duplicate of this issue.
This fixes #103