search

spark-root / laurelin

Allows reading ROOT TTrees into Apache Spark as DataFrames
BSD 3-Clause "New" or "Revised" License
10 stars 4 forks source link

Laurelin improvements (Coveralls.io + CodeClimate API) #60

Closed oshadura closed 5 years ago

oshadura commented 5 years ago

Quick fix: Coveralls.io is actually managing not to generate "noise" in PRs, as well as CodeClimate. (example https://github.com/JMRI/JMRI)

As soon as it will be merged, we can add 2 badges in README.

PerilousApricot commented 5 years ago

Hi @oshadura I don't have a preference either way on what code coverage tool we use (I'll send you the token you requested in a sec), but did you notice that I got it so codecov does one of those status checks too?

Screen Shot 2019-09-25 at 10 01 52 AM
oshadura commented 5 years ago

Hi @oshadura I don't have a preference either way on what code coverage tool we use (I'll send you the token you requested in a sec), but did you notice that I got it so codecov does one of those status checks too?

Screen Shot 2019-09-25 at 10 01 52 AM

Interesting! I didn't see it before in earlier PRs, but now in your latest PR (https://github.com/spark-root/laurelin/pull/61) everything looks good! So then consider please this PR irrelevant...

PerilousApricot commented 5 years ago

Okay! Thanks! Do you think it's still a good idea to integrate CodeClimate too? I'm not familiar with it, so I'll trust your judgement :)

oshadura commented 5 years ago

maybe... it is pretty :)

PerilousApricot commented 5 years ago

Ok! In that case, can you redo your branch to just have the CodeClimate changes and we can work on the token stuff tomorrow via Skype? -- It's dark in this basement.

oshadura commented 5 years ago

Closing in favor of https://github.com/spark-root/laurelin/pull/60