search

sparkapi / sparkapi4p2

A PHP wrapper for the flexmls REST API.
GNU General Public License v3.0
26 stars 28 forks source link

Change wrapped_api_call method to only escape /v1/contacts/tags/<tag> #29

Closed donclem closed 11 years ago

donclem commented 11 years ago

Ok, the whole url was being escaped when it shouldn't have.

But we still needed it to escape whenever calling /v1/contacts/tags/.

So, the new code checks for this.  Couldn't think of any other service that would need to be escaped before hand so just leaving it simple.

ridley-james commented 11 years ago

Given that this check is occurring for one specific instance for every call, I don't think we'd want the overhead of it in the core call method. Also, when using the helper methods for get/put/post/delete, it should be up to the user of the client to ensure they have escaped the URI properly.