search

sparkartgroup-archive / sparkart.js

Easily interact with Sparkart's APIs via Javascript.
1 stars 0 forks source link

[#gZVcpD77] Validate Customer Email Update #67

Closed djiang closed 10 years ago

djiang commented 10 years ago

Branch: gZVcpD77-validate-customer-email-update Issue: SparkartGroupInc/sparkart-services#305 Card: https://trello.com/c/gZVcpD77 Related: SparkartGroupInc/sparkart-tools#209, SparkartGroupInc/sparkart-core#102, https://github.com/SparkartGroupInc/sparkart-services/pull/329

Timo614 commented 10 years ago

Everything looks good to me, I'll give it a try in a little bit when I finish looking over the other branches.

Do we know if KU, UFC, or Young Money override this template? What's the worst that could happen if they are delayed in updating? Will customers be unable to change their email until we get those changes out? If so may be worth adding PRs for those where applicable and prepping UFC changes on Storyteller (I guess locally and copy pasting over and publishing when set -- but be careful if UFC ones are required since who knows what the state the pages are in when you're on it as sometimes the AMs are mid changes or have things prepped for a specific release so good to ask them before publishing).

djiang commented 10 years ago

Looks like KU is using the default template, but UFC and Young Money are using custom templates. Without the new template, users will still be able to update their emails, but the email field will still show their current (active) email until their new email is confirmed.

I believe UFC and YM are both on (old) Storyteller, so I can't add a pull request. But it looks like they were recently published, so we might be able to update sparkart.js and the template soon after release.

Timo614 commented 10 years ago

Gotcha, as long as lacking the field isn't going to cause issues with the account update in general I think it's fine. We'll just need to address it after the release, :+1:, can you add a checklist or something so we don't forget to update them in case we end up deploying late in the week after this stuff has gone out?

djiang commented 10 years ago

Added post release checklist to card template