search

sparkartgroup / slush-solidus

A slush generator for Solidus sites.
MIT License
0 stars 0 forks source link

Doesn't create .npmrc files #4

Closed localjo closed 8 years ago

localjo commented 8 years ago

Our current setup with docker-solidus relies on .npmrc files in the site's repo. For some reason, even though the .npmrc file exists in the template, it's not being cloned on slush solidus. This might be related to the issue here: https://github.com/gulpjs/gulp/issues/1523

localjo commented 8 years ago

Judging by the info here: https://docs.npmjs.com/files/npmrc#files

We might have to manually create an .npmrc file after initializing a new repo, and manually set permissions to 0600 before running npm install. I'm surprised we haven't run into any issues with this before now. cc @joanniclaborde @pushred

joanniclaborde commented 8 years ago

Have you tried setting an NPM_TOKEN env variable before running your script?

localjo commented 8 years ago

The issue was that npm i -g ./slush-solidus was skipping .npmrc, so by the time slush solidus was run, that file was already missing. Fixed by https://github.com/SparkartGroupInc/slush-solidus/commit/4674837a592563a8cd09a6c4d3c980961e4d0d95