sparkbox / apprentice-at

An online listing of apprenticeship opportunities.
https://apprentice.at/
3 stars 4 forks source link

fix: all page content must be contained by landmarks #286

Open corinneling opened 3 years ago

corinneling commented 3 years ago

To meet WCAG best practice we want to make sure all elements are located within landmarks. For more information view Deque's page on the issue

To fix this, move the markup in the _report.hbs file into the _footer.hbs file

Make sure the markup from the report file is contained within the <footer> tags

Also, make sure to remove references to the report partial from all page templates located here

See screenshot on aXe audit result regarding this issue:

Screen Shot 2020-10-05 at 7 36 38 PM

And a screenshot of the report text on the home page: apprentice-at-report

anastasialanz commented 3 years ago

I'll do this one. 😄