sparkbox / apprentice-at

An online listing of apprenticeship opportunities.
https://apprentice.at/
3 stars 4 forks source link

Refactor: Update form validation #329

Closed saashapina closed 2 years ago

saashapina commented 2 years ago

Testing

cypress[bot] commented 2 years ago



Test summary

13 0 0 0


Run details

Project apprentice-at
Status Passed
Commit 79cc395d58
Started Feb 24, 2022 6:20 PM
Ended Feb 24, 2022 6:22 PM
Duration 01:28 💡
OS Linux Ubuntu - 20.04
Browser Custom chromium 90

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

jonoliver commented 2 years ago

👏 This is awesome @saashapina!

The UI behavior is much more consistent and jquery validate makes the configuration easier! 🎉

Two minor things I noticed:

  1. when the validation applies to an invalid url, the input value changes to upper case. Not sure if that's intended, but it seems a bit jarring IMO
  2. Invalid inputs appear nearly identical to error messages, making it difficult to visually discern between them. Maybe tweaking the error message styling a bit would help? image