search

sparkbox / bouncy-ball

:red_circle: Compare web animation techniques by bouncing a ball with each one.
https://sparkbox.github.io/bouncy-ball
MIT License
605 stars 66 forks source link

Flash demo not working, even with Ruffle #117

Closed torokati44 closed 6 months ago

torokati44 commented 6 months ago

The Flash demo is hard-coded to be unsupported, even though, with Ruffle, it works.

I recommend something similar to this method: https://stackoverflow.com/a/42815720/635587 In place of this: https://github.com/sparkbox/bouncy-ball/blob/7f2f5ca70d5f7eaf2003e219a3ef9c6d21fc5dae/site/js/updatePanes.js#L89-L92

danielhjacobs commented 6 months ago

I suggest switching return false to return !!navigator.plugins.namedItem("Shockwave Flash"). This is also useful for browsers that can still support Flash, like Pale Moon or Basilisk.

bryanbraun commented 6 months ago

Great idea. I tested this with Ruffle and it works. 🙌

Screenshot 2024-02-03 at 6 43 05 AM

Pushing this up now.

torokati44 commented 6 months ago

It's a bit cut off on the right, not sure if that's Ruffle's fault, or the SWF is just like that. Would have to check in Flash Player to be sure.