search

sparkbox / bouncy-ball

:red_circle: Compare web animation techniques by bouncing a ball with each one.
https://sparkbox.github.io/bouncy-ball
MIT License
605 stars 66 forks source link

Add ng2 example #36

Closed perryjr closed 6 years ago

perryjr commented 7 years ago

I caught @bryanbraun 's great talk on animation last week and was inspired to add an example using Angular 2.

bryanbraun commented 7 years ago

@perryjr, thanks for your PR.

I've been thinking about this PR, and these "framework" type of examples (Angular, React, Ember, etc).

They aren't exactly animation techniques themselves, so these examples have a slightly different purpose. Instead of "comparing animation approaches" they teach "how to create animations within a given framework". Still educational, but different.

I think there's a place for having these comparisons but maybe not mixed in with the other purely animation approaches on the site. I'm thinking about updating the UI to have a place for framework specific comparisons. This would help with other problems, like which code do I display in the code-view when the app is made from a collection of files?

In short, until I get the UI updated I'll probably have to leave this PR unmerged.

bryanbraun commented 6 years ago

I'm going to close this for now. If I get to the point where I'm looking to add more framework-style examples, I'll ping you back on this issue and we can reopen/resubmit this one.