sparkbox / bouncy-ball

:red_circle: Compare web animation techniques by bouncing a ball with each one.

https://sparkbox.github.io/bouncy-ball

MIT License

605 stars 66 forks source link

fixed react ff issue #51

Closed sloansparger closed 6 years ago

sloansparger commented 6 years ago

27

bryanbraun commented 6 years ago

Hey @sloansparger, thanks for looking at this, and you're right, the issue was the missing rate parameter.

It turns out, there was already a PR up fixing this (#50) before yours, so I went ahead and merged that one, and will end up closing this one. It's probably my fault for not getting to that one fast enough (and also, nothing was mentioned in that issue, when the PR went up 🤷‍♂️ ).

Thanks again. 💯

sloansparger commented 6 years ago

@bryanbraun no worries 👍