search

sparkbox / bouncy-ball

:red_circle: Compare web animation techniques by bouncing a ball with each one.
https://sparkbox.github.io/bouncy-ball
MIT License
605 stars 66 forks source link

Adding Popmotion example #54

Closed mattgperry closed 6 years ago

bryanbraun commented 6 years ago

Hey, thanks for the PR! I've been meaning to get Popmotion added to this at some point. 😄

The code looks great at a glance. Most of the other libraries are pulled in via CDN... having a local copy works too, but it's hard to tell which version of popmotion this is, and know when to update it. If we aren't pulling in the library via CDN, can we add a version number to the file name or a comment or something?

Other than that, I should be able to test this out later this week. 👍

mattgperry commented 6 years ago

Good point, I was just copying one of the other dirs but this makes more sense. I've updated it with a CDN reference!

bryanbraun commented 6 years ago

This looks good. It looks like you accidentally deleted the wrong file in that latest commit, but no worries. I've swapped it back in and tested it locally and it all looks great, so I'll just add that commit on top.

Thanks again for the contribution. This makes 19 examples! 🙌

mattgperry commented 6 years ago

Thanks man sorry for the fuck up! On Tue, 19 Dec 2017 at 22:37, Bryan Braun notifications@github.com wrote:

Merged #54 https://github.com/sparkbox/bouncy-ball/pull/54.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sparkbox/bouncy-ball/pull/54#event-1395108490, or mute the thread https://github.com/notifications/unsubscribe-auth/AHfLKipK8Q6vQ18o8GrZAldgpqqfgU7Mks5tCDq2gaJpZM4RFYbj .