sparkfabrik / android-build-action

Build Android project, export .apk, optional upload to BrowserStack App Live.
MIT License
122 stars 21 forks source link

feat: add support for incrementing the version name #27

Open luke-rogers opened 1 year ago

luke-rogers commented 1 year ago

Add support for incrementing the version name via the increment_version_name plugin

edodusi commented 1 year ago

@luke-rogers I think we should use gradle properties to better handle versioning. So for example, taken from the fastlane docs:

gradle(
  # ...

  properties: {
    "android.injected.version.code" => 100,
    "android.injected.version.name" => "1.0.0",
    # ...
  }
)

Here we can set the version name to a specific value. This requires also a change in the app/build.gradle but so is using this plugin.

What do you think?

luke-rogers commented 1 year ago

I did go down a similar route when starting this but seemed to run into the issue documented here, hence switching to use the plugin instead. Although that was using the version overrides, rather than updating app/build.gradle directly.