sparkfabrik / android-build-action

Build Android project, export .apk, optional upload to BrowserStack App Live.
MIT License
121 stars 21 forks source link

path '.' duplicate last dir #31

Open gcb opened 1 week ago

gcb commented 1 week ago

using project_path: . when gradlew is on the repo root will fail the build with

Couldn't find gradlew at path '/home/runner/work/repo_name/repo_name/gradlew'

# minimum reproducible case using job from README
jobs:
  maybe-build-android:
    runs-on: ubuntu-latest
    steps:
      - uses: sparkfabrik/android-build-action@v1.5.0
        with:
          project-path: .
          output-path: my-app.apk
          browserstack-upload: false
          ruby-version: "2.7.5"
          bundler-version: "2.3.26"
          fastlane-env: "debug"
gcb commented 1 week ago

trying to look at the code but searching for PROJECT_PATH only shows where it is assigned to env, :shrug:

gcb commented 1 week ago

Also tried project_path: ./ same error.

With project_path: ../ error actually shows the correct place for gradlew

[!] Couldn't find gradlew at path '/home/runner/work/repo_name/gradlew'

gcb commented 1 week ago

seeing https://github.com/fastlane/fastlane/blob/HEAD/fastlane/lib/fastlane/setup/setup.rb#L61

i tried to fake a directory there with

project-path: ../../repo_name but it ends up the same as ../

[!] Couldn't find gradlew at path '/home/runner/work/repo_name/gradlew'