feat: use a more intelligent regexp

[paolomainardi]

PR Type

Enhancement

---

Description

• Simplified the macOS playbook import process by using a more intelligent regular expression
• Consolidated multiple version-specific imports into a single, more inclusive import
• Updated regex to support macOS versions 12 through 15, allowing for future compatibility
• Reduced code duplication and improved maintainability by removing redundant playbook imports
• Improved overall efficiency of the Ansible playbook for macOS configurations

---

Changes walkthrough 📝

	Relevant files
Enhancement	macos.yml Streamline macOS playbook import with improved version detection ansible/macos.yml Simplified playbook import for macOS versions 12-15 Replaced multiple version-specific imports with a single import using a more inclusive regex Removed redundant playbook imports for individual macOS versions +2/-10

---

💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[sparkfabrik-ai-bot[bot]]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Version Compatibility The new regex pattern assumes macOS versions up to 15, which may not cover future releases beyond that.

[sparkfabrik-ai-bot[bot]]

PR Code Suggestions ✨

Category	Suggestion	Score
Enhancement	Improve the regex pattern for version matching to ensure more accurate results ___ **Consider using a more specific regex pattern to match macOS versions. The current pattern might match unexpected versions like '150.0'.** [ansible/macos.yml [7-9]](https://github.com/sparkfabrik/sparkdock/pull/88/files#diff-74eaffaddb7e6ee392f81e5060f6bea50b791cdb80f2292b2257c744fb4e0e38R7-R9) ```diff - name: Import playbook for macOS import_playbook: macos/macos/base.yml - when: ansible_distribution_version | regex_search('^(1[2-5].[0-9]+)') + when: ansible_distribution_version | regex_search('^(1[2-5]\.[0-9]+)') ``` Suggestion importance[1-10]: 8 Why: The suggestion correctly identifies a potential issue with the regex pattern and proposes a more precise solution, which could prevent matching unintended versions.	8
Maintainability	Add a descriptive comment to clarify the supported macOS versions ___ **Consider adding a comment explaining the version range covered by this playbook import to improve maintainability.** [ansible/macos.yml [7-9]](https://github.com/sparkfabrik/sparkdock/pull/88/files#diff-74eaffaddb7e6ee392f81e5060f6bea50b791cdb80f2292b2257c744fb4e0e38R7-R9) ```diff -- name: Import playbook for macOS +- name: Import playbook for macOS (versions 12.x to 15.x) import_playbook: macos/macos/base.yml when: ansible_distribution_version | regex_search('^(1[2-5].[0-9]+)') ``` Suggestion importance[1-10]: 6 Why: The suggestion improves code readability and maintainability by adding version information to the task name, which is helpful but not critical.	6