Cannot Disable UART FIFO via HAL

sparkfun / AmbiqSuiteSDK

A copy of the AmbiqSuite SDK available on GitHub. Can be used to include AmbiqSuite as a submodule. May be used to track issues in SDK releases, however this repo is not maintained by AmbiqMicro

39 stars 31 forks source link

Cannot Disable UART FIFO via HAL #25

Open oclyke opened 4 years ago

oclyke commented 4 years ago

As evidenced by changes required for this PR in the mbed port it is difficult to fully disable the FIFO on UART while using HAL configuration.

branch 2.4.2-patch-uart-fifo-config adds an additional configuration function which allows the FIFO to be enabled (as usual) or disabled (addtl. feature)

oclyke commented 4 years ago

This issue persists in AmbiqSuite SDK 2.5.1 and has a corresponding patch branch

RichardSWheatley commented 3 years ago

I do not believe your fix works. I believe it does the opposite. buffer_configure already handles the NULL pointers properly whereas you new function ignores the NULL handling.