search

sparkfun / BMP180_Breakout

Breakout board for the Bosch BMP180 barometric pressure sensor
Other
69 stars 101 forks source link

Updates for quality #11

Closed nkolban closed 7 years ago

nkolban commented 7 years ago

Removed an unused variable that served no purpose. Changed a variable type from char to int that was being used only as an array index as my compiler doesn't like chars used as indices.

mgrusin commented 7 years ago

Hi Neil, thanks for looking at this code and your debugging. Re. char to int, I hate to waste a byte of SRAM if I don't have to; how about changing it to a uint8_t? (The whole library could frankly use that for better portability).

mgrusin commented 7 years ago

Also out of curiosity, what compiler / destination processor are you using?

nkolban commented 7 years ago

I'm compiling using xtensa-esp32-elf-gcc which reports as 4.8.5. The target is for the ESP32.

nkolban commented 7 years ago

Changed to uint8_t

mgrusin commented 7 years ago

Thanks VERY much Neil, if you ever see anything else that can be improved, please let us know!