search

sparkfun / ColorLCDShield

This is an Arduino library for SparkFun's Color LCD Shield
http://www.sparkfun.com/products/9363
40 stars 66 forks source link

Added new functionality to setCircle and added new setArc method #8

Closed tonyc770 closed 11 years ago

tonyc770 commented 11 years ago

These changes include addition of Fill and Line thickness of Circles. also added a new setArc method which can generate multiple 45 degree arcs with varying line thickness or filled.

jimblom commented 11 years ago

Cool. Thanks for the help, Tony!

To maintain compatibility with earlier sketches that used the function, I'd like to change the parameter order of setCircle (swap color and lineThickness) and default the lineThickness parameter to 1. Otherwise, these look like great additions. I'll work on getting them added.

tonyc770 commented 11 years ago

Hi Jim,

Yes, that sounds fine. Note also I have an example sketch in the examples folder, so if you make that change can you alter the example as well? Also, note that the setArc method is very useful for creating graphical gauges. I have already done so on one of the Arduino apps I am currently working.

If I come up with anything else I will let you know.

Thanks, Tony

----- Original Message ----- From: "Jim Lindblom" notifications@github.com To: "sparkfun/ColorLCDShield" ColorLCDShield@noreply.github.com Cc: "tonyc770" tony.contrada@comcast.net Sent: Monday, March 4, 2013 3:28:38 PM Subject: Re: [ColorLCDShield] Added new functionality to setCircle and added new setArc method (#8)

Cool. Thanks for the help, Tony!

To maintain compatibility with earlier sketches that used the function, I'd like to change the parameter order of setCircle (swap color and lineThickness) and default the lineThickness parameter to 1. Otherwise, these look like great additions. I'll work on getting them added.

— Reply to this email directly or view it on GitHub .