enable true off for blue LED

sparkfun / OpenLCD

An open source serial LCD (HD44780) controller based on the ATmega328.

Other

32 stars 16 forks source link

enable true off for blue LED #22

Closed ALittleSlow closed 4 years ago

ALittleSlow commented 5 years ago

SoftPWM has a true off (0 is really off), but not a true on (255 is not 100% duty cycle), so invert the logic to be able to fully turn off the blue LED.

lewispg228 commented 4 years ago

Hi @ALittleSlow , Thank you so much for catching this issue and completing this PR. I just tried this out on some hardware, and it looks great. It's very nice to see the blue back light turn completely off. The folks commenting on issue #22, will be happy to see this merged.

Thanks again! -Pete