search

sparkfun / OpenLCD

An open source serial LCD (HD44780) controller based on the ATmega328.
Other
32 stars 16 forks source link

design review for proto v02 #4

Closed lewispg228 closed 8 years ago

lewispg228 commented 8 years ago

1) Is the version number correct? [NO] comment: should be v02 in sch

2) Does it pass SparkFun DRC? [NO] comment: You're really close to passing the STANDARD DRU, please use this and approve the errors caused by the locking header pads getting close to dimension

3) Do all packages have NAME and VALUE? [NO] comment: please change u3's value to MIC5205, rather than just ADJ

4) Is the polarity label outside of the package for visibility after part population? [NO] comment: Please update package for mcp4725 to have polarity mark outside package

nseidle commented 8 years ago

Nice.

1) Fixed.

2) I just ran STANDARD with trace/space changed to 8mil. Passes. Let me know if you are running something different.

3) Fixed.

4) Fixed and library update committed.

lewispg228 commented 8 years ago

Sorry I was unclear in my request for 2, but what I meant was please use the standard dru (without modifying it). And modify the board to pass the dru. It looks like you just have two traces to thicken up to 10 mil, and a 4 vis to nudge.

nseidle commented 8 years ago

Ah! I thought trace/space was optional down to 8mil. Turns out the design can work at 10mil pretty easily. Now passes STANDARD.

lewispg228 commented 8 years ago

Looks good. Just recently, the DFM committee decided that keeping the clearance and trace width at 10 mil is the ideal situation (if there's room). Thanks Nate!