search

sparkfun / OpenLCD

An open source serial LCD (HD44780) controller based on the ATmega328.
Other
32 stars 16 forks source link

Print pipe #7

Closed fourstix closed 6 years ago

fourstix commented 6 years ago

Add function to print the settings command character pipe, by doubling the command character

fourstix commented 6 years ago

Sorry for the terse commit in the pull request. This code adds logic to print a Pipe "|" character to the display. The pipe character is used as the settings command and is currently eaten by the display. Worse if the next character happens to collide with a command, that character will invoke a display setting rather than printing as a pipe. With this change the user can escape the pipe character with two command settings characters, ie "||". For example, "||-2|| = 2" would display on the serLCD as "|-2| = 2". Closes #8

fourstix commented 6 years ago

I think I did the pull request wrong to this repository. I have merged the commit to the master in my fork, and will create the pull request again from master to master. I think that's the way it should be.

fourstix commented 6 years ago

Nevermind. I think I did it right.

nseidle commented 6 years ago

Hi @fourstix - this is awesome. Thanks for contributing!

Issues are good, PRs are GOLD. But I couldn't respond because I've been exploring the caves of your xkcd link for the past three days.

This PR looks good. It looks like a dupe of PR #6. I'll close 6, and the original issue, then merge this one.

Thank you again for your help!