search

sparkfun / OpenLog

Open Source Hardware Datalogger
https://www.sparkfun.com/products/9530
Other
553 stars 216 forks source link

(v3.3) Added support for timestamped logging #159

Closed JanneMantyharju closed 11 years ago

JanneMantyharju commented 11 years ago

This commit adds support to timestamp logged data and includes python program to play back log in real time.

nseidle commented 11 years ago

This is really well written and thank you for submitting a pull request. I'm very nervous of any code that modifies the time critical loop (line 537). Have you do any testing to prove that the record quality isn't degraded by this feature?

Ah - it looks like you did. I'll give it a quick test as well.

nseidle commented 11 years ago

It looks like with the feature turned off, logging quality is as expected (still pretty good at 115200).

That said, I've decided not to merge this feature. I need to keep OpenLog doing nothing but logging. This means leaving the host system to handle all encoding, timestamps, data conversion, etc.

You are one of a few who've wrapped their head around this entire codebase - nice work! Please consider helping with core features in the future. Let me know if we can do anything for you in the future.

JanneMantyharju commented 11 years ago

Ok, thanks for info. The timestamp code will remain in my repository if someone else would need this feature.

br, Janne

On 23.9.2013, at 6.08, Nathan Seidle notifications@github.com wrote:

It looks like with the feature turned off, logging quality is as expected (still pretty good at 115200).

That said, I've decided not to merge this feature. I need to keep OpenLog doing nothing but logging. This means leaving the host system to handle all encoding, timestamps, data conversion, etc.

You are one of a few who've wrapped their head around this entire codebase - nice work! Please consider helping with core features in the future. Let me know if we can do anything for you in the future.

— Reply to this email directly or view it on GitHub.