fix package install issues

sparkfun / Qwiic_Ublox_Gps_Py

https://qwiic-ublox-gps-py.readthedocs.io/en/latest/index.html

Other

70 stars 41 forks source link

fix package install issues #5

Closed toddtreece closed 4 years ago

toddtreece commented 4 years ago

why

the published version of this package is currently broken, and it looks like others are having issues as well (see #4).

what

move ublox_gps -> qwiic_ublox_gps and updates example imports
switch from py_modules to packages in setup.py
fixes core import
adds AttributeError to catch exceptions in examples (without this examples would exit after one message)

edspark commented 4 years ago

I really appreciate the pull request and I'm sorry you went through all of the trouble. I pushed a number of things before I saw the pull request, but I also had to add more things, fix other things etc. The install does work if you have version 1.1.3.

toddtreece commented 4 years ago

@edspark no worries at all! it only took a couple mins to get running locally so i thought i'd share in case it helped.

one thing i did notice, i still get messages like this with 1.1.3:

AttributeError: 'ORB' object has no attribute 'lon'

i was working on a parser last weekend in a different language and used this lib to compare results, so i'm guessing this might be because i enabled messages that the examples weren't expecting.

edspark commented 4 years ago

Ah, your addition of the Attribute Error is a good idea none the less. In exactly this case where people might be adding asking for the incorrect field from the namedtuple. I'll make sure to add it to the examples. Thanks @toddtreece !