name 'hMSLHp' is not defined

sparkfun / Qwiic_Ublox_Gps_Py

https://qwiic-ublox-gps-py.readthedocs.io/en/latest/index.html

Other

69 stars 41 forks source link

name 'hMSLHp' is not defined #9

Closed DanNsk closed 1 year ago

DanNsk commented 3 years ago

Cannot retrieve high precision coordinates, because variable read on line 624 of ublox_gps.py is hMSLHp, supposed to be height_sea (as on line 615) , but parameter name supposed to be hMSLHp . so

    nav_payload = nav_payload._replace(height_sea=hMSLHp * 0.1)

needs to be changed to

   nav_payload = nav_payload._replace(hMSLHp = height_sea * 0.1)

LarsJaeger commented 3 years ago

I can confirm this.

wcb-keshav commented 2 years ago

How have they not corrected this yet!

edspark commented 1 year ago

This is fixed, thanks @DanNsk