sparkfun / SF32u4_boards

Support files for SparkFun's 32u4-based Arduino-compatible development boards.
70 stars 75 forks source link

In pins_arduino.h correspondence between bit mask and pin PD5 is missing, while PD4 is repeated as D24, so D24 should be PD5 #15

Closed dmjlambert closed 9 years ago

dmjlambert commented 9 years ago

In Leonardo hardware pin assignment, the correspondence between bit mask and pin PD5 is missing, while PD4 is repeated as D24, so D24 should be PD5. This is issue 3129 in arduino/Arduino and I would like to see it also fixed for the SparkFun SF32u4 boards please.
https://github.com/arduino/Arduino/pull/3129

This will let us blink the TXLED with pin 24, similar to the way we blink the RXLED with pin 17.

dmjlambert commented 9 years ago

This would also apply to sparkfun/Arduino_Boards, is a separate issue needed there to address this or will this issue suffice?

rafacouto commented 9 years ago

@dmjlambert Arduino project leaders should merge rafacouto/Arduino@876669e2921365238b9772443b8cf5a42dfd11fa to avoid desynchronized branches. Thank you for confirming arduino/Arduino#3129

BrentWilkins commented 9 years ago

I've added support for D24 in both repos. Let us know if you discover any more issues.