search

sparkfun / Serial7SegmentDisplay

Example code and board files for the Serial 7 Segment Display.
https://www.sparkfun.com/products/11629
95 stars 73 forks source link

Conversion to SevSeg library #3

Closed nseidle closed 12 years ago

nseidle commented 12 years ago

I branched a library called SevSeg from the Arduino Playground: http://arduino.cc/playground/Main/SevenSegmentLibrary and improved it a bit (I think).

SevSeg library supports both common anode and cathode. Please test. If you like, and want SevSeg in the main branch of Serial7Segment, then I plan to make many smaller firmware changes (that are not related to how segments are actually displayed).

In just a second I plan to move the SevSeg library over to sparkfun main branch.

I need to get the products with a ATmega type backpack (Serial7Segment and OpenSegment) to this library so that we can use similar code, but with different pin definitions.

jimblom commented 12 years ago

Looks like the SevSeg library will need some modification to work with the Serial7SegmentDisplay's display - it doesn't look to support the colon and apostrophes off on their own anodes.

The brightness control will need to be addressed either here or in the SevSeg library as well. Right now, setting it to the dimmest setting creates some extreme blinkiness. I feel like it could be brighter too.

Using a common library seems like a good ultimate goal for this and other OpenSegment projects, though. I'll work on moving it in that direction.

nseidle commented 12 years ago

I'm not entirely sure what I just did, but my intent was to let you know I updated your comment structure from /* to //. I tried to do a pull request, but could not because this issue was open. Clicked on some things and then this issued closed with the changes I made tonight. Oddness. Let me know what it looks like from your end.

jimblom commented 12 years ago

Hmm, yup all the SevSeg library additions were merged in as well. Those don't currently work with the display because of the problems I mentioned earlier.

I'd really like to have a working version of the code hosted here, as these are beginning to go live. I see you're making a lot of great changes to get rid of the serial ISR, etc. I don't want to overwrite those, so I created a branch with the latest version of working code: https://github.com/sparkfun/Serial7SegmentDisplay/tree/v3.1_live. Maybe we can just point there from the live pages. This also would have the benefit of maintaining transparency, as that's near enough (only comment changes?) the version shipping on the current product.

nseidle commented 12 years ago

Sorry for screwing things up. Genius! I suddenly see the benefit of branches. I'll continue to hammer on the experimental branch.