search

sparkfun / SparkFun-KiCad-Libraries

SparkFun's KiCad Libraries
524 stars 108 forks source link

Usbpd parts #77

Closed lewispg228 closed 5 months ago

nseidle commented 5 months ago

image

image

image

Is the POWERDVFN really unique or should it be in the Semiconductor-Standard library?

Would it make sense to combine pads 5/6/7 into one pad? You may see DRC errors down the road if you don't.

TVS diode looks good.

STLP MOSFET symbol looks good.

lewispg228 commented 5 months ago

Would it make sense to combine pads 5/6/7 into one pad? You may see DRC errors down the road if you don't.

Good call. I learned how to create complex shaped pads. It was throwing an OpenGL error, and I thought it was due to polygon line thickness (0mm or <0.01mm), but now I can't seem to replicate the error. So I think this footprint is good to go.

FWW, this is the error I was seeing:

image

Is the POWERDVFN really unique or should it be in the Semiconductor-Standard library?

It seems that this is a vendor specific package - ST's "PowerFLAT-3.3x3.3-8". Although they do have a collection of these parts, I'm leaning towards keeping it as "non-standard".

lewispg228 commented 5 months ago

Well, in the process of updating the name to PowerFLAT, I found the "6" version in the Package_SON library (ST_PowerFLAT-6L_5x6mm_P1.27mm).

Maybe it should go in the Package_SON library. I'll look into doing a PR there next.

image

nseidle commented 5 months ago

Let me know when you're ready for another review.

lewispg228 commented 5 months ago

Hey @nseidle , This PR is ready for another review. Thanks!

PS Sorry for the delay and mis-understanding here. When I read "Standard", I thought you meant these Kicad Libraries. After going down that rabbit hole, I have now moved it into our SparkFun-Semiconductor-Standard libraries.