sparkfun / SparkFun-KiCad-Libraries

SparkFun's KiCad Libraries
524 stars 108 forks source link

Add SMD CBI LED Footprints #95

Closed NPoole closed 1 month ago

NPoole commented 2 months ago
sfe-SparkFro commented 2 months ago

The reference designator is in the Silkscreen layer, should be Fab

image

sfe-SparkFro commented 1 month ago

Also, the holes are missing cutouts for the top and bottom solder mask

sfe-SparkFro commented 1 month ago

Actually, the holes are defined as edge cuts. IMO would be better to define them as actual holes, similar to the USB-C footprint. Set the type to "NPTH, Mechanical", then select "None" under "Copper layers". The "Pad shape" determines the soldermask, and the "Hole shape" determines the hole itself.

nseidle commented 1 month ago

I made a bunch of changes on my local copy (added courtyard, etc). I'm going to close this, open a new one with my changes, and add your changes @sfe-SparkFro. BRB.