sparkfun / SparkFun_AS3935_Lightning_Detector_Arduino_Library

Other
37 stars 19 forks source link

Error when compiling with 1.4.7 #20

Closed lazaroofarrill closed 12 months ago

lazaroofarrill commented 12 months ago

Subject of the issue

I get the following error when compiling with the 1.4.7 with platformio. This does not happen in 1.4.6

Steps to reproduce

Adding the dependency to platformio.ini

lib_deps = 
    https://github.com/sparkfun/SparkFun_AS3935_Lightning_Detector_Arduino_Library.git#v1.4.7

Expected behavior

The code should compile.

Actual behavior

The build fails with the following error.

.pio/libdeps/esp32doit-devkit-v1/SparkFun AS3935 Lightning Detector Arduino Library/src/SparkFun_AS3935.cpp: In member function 'void SparkFun_AS3935::setIndoorOutdoor(uint8_t)':
.pio/libdeps/esp32doit-devkit-v1/SparkFun AS3935 Lightning Detector Arduino Library/src/SparkFun_AS3935.cpp:96:8: error: expected '(' before '!' token
     if !(((_setting == INDOOR) xnor (_setting == OUTDOOR)))
        ^
        (
edspark commented 12 months ago

Fix coming shortly

edspark commented 12 months ago

Fixed!