search

sparkfun / SparkFun_ATECCX08a_Arduino_Library

An Arduino library to use with the Microchip ATECCX08a Cryptographic Co-processors.
https://www.sparkfun.com
Other
36 stars 18 forks source link

Initial support for ESP8266 #4

Closed NdK73 closed 4 years ago

NdK73 commented 4 years ago

I've just started testing with ESP8266 and had to slightly modify the code. Should I continue and send other PRs if needed?

lewispg228 commented 4 years ago

Hi @NdK73 , Thanks for your pull request on this. Yes please, do continue to work on this!

Your current modifications look good and I don't see them conflicting with anything. I'm curious to know what other tweaks are needed to make this compatible with an ESP8266.

Feel free to continue on from master, but I did want to let you know that there is some other great improvements being made by @gili-yankovitch on this pull request 3. This will most likely be merged in soon. If you wanted to, it might be a good idea to take a look at this PR, just to keep in mind, as this could make merging your PR in later a bit easier.

Thanks again and we look forward to seeing your commits on this PR.

Cheers! -Pete

NdK73 commented 4 years ago

I think it's probably better to change the second commit with delay() calls. Closing and I'll send a new PR later. If PR3 gets included before, I'll use it as a base for mine.