search

sparkfun / SparkFun_Alphanumeric_Display_Arduino_Library

Arduino Library for the SparkX Qwiic Alphanumeric Display
Other
22 stars 13 forks source link

Enahancement: As a user user I need to change the segment mapping for an existing character #5

Closed fourstix closed 4 years ago

fourstix commented 4 years ago

This pull request moves the character map into PROGMEM and adds previously missing characters to the table to simplify the map logic.

A function is added to define a character segment map to a list. The list is checked before a character is displayed from the default character map table. An example is provided to show the use of this function.

Lastly, a previous stray debug serial print statement is commented out, and the period and colon characters are changed to blanks so the display is not corrupted when the fixed decimal point or colon is displayed.

All previous examples were run as a regression test.

fourstix commented 4 years ago

This pull request will close #5 and incorporates the suggestions from @nseidle

makin-stuff commented 4 years ago

Hey @fourstix. I'm working to merge your pull request. Can you please change the version number in library.properties to 1.1.1 so that I can do a release once merged?

fourstix commented 4 years ago

@pmakin-png I updated the version to 1.1.1 as requested. So you should be able to do the merge now.