Closed drhideg closed 4 years ago
@drhideg I like what you've done here, but we usually don't like customers having to fiddle about in the library's source files to enable or disable features. I understand that you have a default to I2C if the customer doesn't define anything, but this still means the customer has to go into the library to enable SPI. For now I don't think I can pull this request in, I'm sorry.
I hope i dont make any wrong, therefor both I2C and SPI enabled by default. At least that was my intention. However i dont have any SPI device to try it on board.
-- Github stuffs is new for me. I need to close or delete my for to any of my new commits dont came here as part of a pull reqest? Because the global instances comes here :/
@drhideg Oh I see what you're doing now, the double negatives had me thrown off for a second, can you please update the version number in library.properties to 2.0.9 and I will pull this in
Bumped. But now its all wrong with the global intances things, which doesn't work yet, and i made a typo in the commit title :) Can I close this PR and open a new one from a newly forked library?
Go right ahead!
Added _SPARKFUNBME280_NO_SPI and _SPARKFUNBME280_NO_I2C compile flag for smaller binary size.