sparkfun / SparkFun_BME280_Arduino_Library

An Arduino library to control the BME280 humidity and pressure sensor.
https://www.sparkfun.com/products/14348
Other
120 stars 113 forks source link

Calibration value H6 should be a signed char. #8

Closed jkfritcher closed 6 years ago

jkfritcher commented 7 years ago

See BME280 datasheet, pg 23.

In the code, H6 is specified as a uint8_t, but the datasheet says H6 is a signed char. This PR changes H6 to be an int8_t

The change compiles and runs correctly with a SparkFun BME280 breakout.

nseidle commented 6 years ago

Good catch. We're a little (ok a lot) late to reviewing this. Thanks for the PR!