Added getters for multiple variables at the same time

sparkfun / SparkFun_BNO080_Arduino_Library

An Arduino Library for the BNO080 IMU combination triple axis accelerometer/gyro/magnetometer packaged with an ARM Cortex M0+ running powerful algorithms.

Other

81 stars 62 forks source link

Added getters for multiple variables at the same time #56

Closed guihomework closed 4 years ago

guihomework commented 4 years ago

As discussed here #55 , this PR adds getters for multiple variables at the same time, also avoiding extra data copy.

Example was tested on SPI1 on a teensy 4.0 but can be modified to test on a standard i2c bus that I cannot test right now immediately

guihomework commented 4 years ago

Hi @PaulZC thanks for reviewing and sorry for the bad PR, not looking carefully about the existing examples, not noticing there were SPI separate examples and not being aware that a renaming campaign is underway in the world of programming/electronics.

I hope I tackled all your remarks, but cannot test i2c or spi code in generic fashion. I re-tested with my teensy4.0 while uncommenting the required lines.

PaulZC commented 4 years ago

Hi @guihomework , Don't worry! It is a very nice PR. It just needs a little "fine tuning". I will merge and test this as soon as I can - but it might not be until Monday. Best wishes - and thank you again, Paul

PaulZC commented 4 years ago

Thanks again for this PR - and for making the changes! I am merging this into the release-candidate branch so I can test it. I will merge into the master branch when we release v1.1.9.