sparkfun / SparkFun_External_EEPROM_Arduino_Library

An Arduino library for the easy control of external I2C EEPROMs.
Other
54 stars 14 forks source link

Changes to default settings and memory size computation #17

Closed wolfbert closed 1 year ago

wolfbert commented 2 years ago

As per issue #16.

I wasn't able to test the settings, as I don't have large size EEPROMs available. Code compiles ok und runs with 32KB EEPROM.

wolfbert commented 2 years ago

Just noticed a possible side effect. The default page size is now 128 (as stated in the datasheet) instead of 64. This might break existing code, in case someone e.g. just changes the memory size for a different EEPROM and accepts the default page size. Change back to 64?

nseidle commented 1 year ago

PR looks good! Thanks. I agree, let's leave the default at 64. I'll fix it after merge.