sparkfun / SparkFun_ICM-20948_ArduinoLibrary

Arduino support for ICM_20948 w/ portable C backbone
Other
160 stars 70 forks source link

Unused variables b2sMountMultiplierZero[] and b2sMountMultiplierPlus[] #44

Closed mfide closed 3 years ago

mfide commented 3 years ago

Hi,

Thank you for this huge effort.

In your example codes Example6 and 9, you are initializing matrix registers of the DMP, but b2sMountMultiplierZero[] and b2sMountMultiplierPlus[] are never used in the initializer. Was that intentional or a bug?

// Configure the B2S Mounting Matrix
  const unsigned char b2sMountMultiplierZero[4] = {0x00, 0x00, 0x00, 0x00};
  const unsigned char b2sMountMultiplierPlus[4] = {0x40, 0x00, 0x00, 0x00}; // Value taken from InvenSense Nucleo example
  success &= (myICM.writeDMPmems(B2S_MTX_00, 4, &mountMultiplierPlus[0]) == ICM_20948_Stat_Ok);
  success &= (myICM.writeDMPmems(B2S_MTX_01, 4, &mountMultiplierZero[0]) == ICM_20948_Stat_Ok);
  success &= (myICM.writeDMPmems(B2S_MTX_02, 4, &mountMultiplierZero[0]) == ICM_20948_Stat_Ok);
  success &= (myICM.writeDMPmems(B2S_MTX_10, 4, &mountMultiplierZero[0]) == ICM_20948_Stat_Ok);
  success &= (myICM.writeDMPmems(B2S_MTX_11, 4, &mountMultiplierPlus[0]) == ICM_20948_Stat_Ok);
  success &= (myICM.writeDMPmems(B2S_MTX_12, 4, &mountMultiplierZero[0]) == ICM_20948_Stat_Ok);
  success &= (myICM.writeDMPmems(B2S_MTX_20, 4, &mountMultiplierZero[0]) == ICM_20948_Stat_Ok);
  success &= (myICM.writeDMPmems(B2S_MTX_21, 4, &mountMultiplierZero[0]) == ICM_20948_Stat_Ok);
  success &= (myICM.writeDMPmems(B2S_MTX_22, 4, &mountMultiplierPlus[0]) == ICM_20948_Stat_Ok);
PaulZC commented 3 years ago

Hi Mehmet (@mfide ), Oops. Yes. That's a bug. I should be using b2sMountMultiplierZero there, not mountMultiplierZero. Strictly, it probably does not matter as we are not using the B2S. But I will fix it... Best wishes, Paul

mfide commented 3 years ago

accelAVar[] is also never used. Next to the above code. const unsigned char accelAVar[4] = {0x0B, 0x6D, 0xB6, 0xDB}; // 56Hz

PaulZC commented 3 years ago

Thanks Mehmet! I thought I'd fixed that! But maybe I only fixed it in some of the examples, not all... Best wishes, Paul

PaulZC commented 3 years ago

No. Clearly I didn't... Updated examples will be released very soon. Thanks again, Paul