sparkfun / SparkFun_Qwiic_9DoF_IMU_Breakout

The ICM20948 is the next IMU in the lineup from Invensense, following the MPU-9250
Other
15 stars 6 forks source link

ENG check: REDS #2

Closed ericorosel closed 5 years ago

ericorosel commented 5 years ago

1) BOM needs PCB

2) NO qwiic labels on board (not sure if this is qwiic or not)

3) DRC errors need approval

4) Designer name label in BRD needs re positioning

5) AD0 has an extra segment of trace and via

6) Scoot mag. axis silk away from board edge slightly

7) PWR silk overlaps ICM polarity silk

8) i2c pin order is incorrect based on our standard

thoughts:

oclyke commented 5 years ago
  1. Added PCB to BOM, and built in a reminder to the BOM ULP to do the same
  2. Changed the name to "SparkFun 9DoF IMU Breakout - ICM-20948 (Qwiic)" and now the silk name reads "Qwiic 9DoF IMU /n ICM-20948"
  3. Will not flip the board after approving DRC errors
  4. Fixed
  5. Fixed
  6. Done
  7. Adjusted ICM package so as not to overlap

Going to work on number 8 in another unit

oclyke commented 5 years ago

Alright, managed to solve item 8 with a little re-routing and by shortening SDA and SCL to DA and CL respectively in silk. I think this is all wrapped up

oclyke commented 5 years ago

For the record item 8 was solved in commit 1bc5ff4