Redundant options in Example2_SetOptions.ino

sparkfun / SparkFun_SCD30_Arduino_Library

An Arduino library for the SCD30 NDIR CO2 sensor.

Other

84 stars 47 forks source link

Redundant options in Example2_SetOptions.ino #15

Closed alfkoehn closed 3 years ago

alfkoehn commented 3 years ago

In the file examples/Example2_SetOptions/Example2_SetOptions.ino, there are both, airSensor.setAltitudeCompensation() and airSensor.setAmbientPressure() performed. The document Interface Description Sensirion SCD30 Sensor Module from Sensirion, however, states that Setting altitude is disregarded when an ambient pressure is given to the sensor (Section 1.4.8)

One could maybe add this information as a comment to the file Example2_SetOptions.ino

nseidle commented 3 years ago

Thanks to @awatterott, some new comments have been added. Please review and re-open if they are not sufficient.