sparkfun / SparkFun_SGP30_Arduino_Library

This is an Arduino library for the SGP30 Air Quality Sensor
Other
13 stars 10 forks source link

Warning when compiling the examples #2

Closed vidaljuanp closed 5 years ago

vidaljuanp commented 5 years ago

Subject of the issue

Warning when compiling the examples

Your workbench

Steps to reproduce

Open example Basic Readings on arduino IDE and compile

In file included from SparkFun_SGP30_Arduino_Library-master/examples/Example2_RawSignals/Example2_RawSignals.ino:17:0: SparkFun_SGP30_Arduino_Library-master/src/SparkFun_SGP30_Arduino_Library.h:144:13: warning: extra qualification 'SGP30::' on member '_CRC8' [-fpermissive] uint8_t SGP30::_CRC8(uint16_t twoBytes); ^ In file included from SparkFun_SGP30_Arduino_Library-master/src/SparkFun_SGP30_Arduino_Library.cpp:40:0: SparkFun_SGP30_Arduino_Library-master/src/SparkFun_SGP30_Arduino_Library.h:144:13: warning: extra qualification 'SGP30::' on member '_CRC8' [-fpermissive] uint8_t SGP30::_CRC8(uint16_t twoBytes);

Expected behaviour

No warnings or errors when compiling the examples

Actual behaviour

nseidle commented 5 years ago

Compiles w/o warnings on uno. Fails on SAMD21. Must be compiler setting related but I did find the bug. We had an extra SGP:: qualifier in the class. Removed and pushed. Should be fixed in the next lib version release (here in a couple minutes).

Thanks for reporting!