search

sparkfun / SparkFun_SX1509_Arduino_Library

Arduino library for the SX1509 16-I/O GPIO expander.
44 stars 38 forks source link

keypad initialization errors #1

Open tbatmanb opened 8 years ago

tbatmanb commented 8 years ago

Hi, the keypad init routine contains two errors which are leading to wrong operation of other IO Pins.

please modify lines 349, 350, 537, 538 as shown below. old 349 for (int i=8; i<(columns * 2); i++) // this couldn't work as desired old 350 tempWord |= (1<<i);

new 349 for (int i=0; i<columns; i++) // this way, it works as desired new 350 tempWord |= (1<<(i+8)); // <--- i+8

old 537 for (int i = 0; i < (8 + numCols); i++) // this couldn't work as desired old 538 debouncePin(i);

new 537 for (int i = 0; i < (numCols); i++) // this way, it works as desired new 538 debouncePin(i + 8); // <--- i+8

;-) one beer less ware best regards thomas

gb-123-git commented 11 months ago

I think this has already been solved, as refered in #7 so it can be closed.