search

sparkfun / SparkFun_SX1509_Arduino_Library

Arduino library for the SX1509 16-I/O GPIO expander.
44 stars 38 forks source link

Adapted for use with TwoWire (and removed Wire.begin() from inside library) #9

Closed stephenf7072 closed 2 years ago

stephenf7072 commented 4 years ago

Seems like bad practise to Wire.begin() inside library, so it's been removed. This does make the library not backwards compatible with previous code.

nseidle commented 2 years ago

This is much appreciated. I agree about moving the Wire.begin out of the library, but it also breaks all previous sketches because the device address is passed in as first argument and this PR passes Wire in first. Easy enough to fix. I'll merge and sort it out and bump to v3 because we are breaking previous compatibility (slightly).

pageclosers commented 2 years ago

Awesome, glad it's useful.