search

sparkfun / SparkFun_SerLCD_Arduino_Library

A library to seamlessly control the SparkFun SerLCD over I2C, SPI, and Serial.
MIT License
23 stars 10 forks source link

[Constructor]: missing possibility to set base values via contructor #5

Closed hasenradball closed 4 years ago

hasenradball commented 4 years ago

I am missing the possibility to easily set up the main LCD settings via constructor, like:

// constructor with address, cols, rows SerLCD lcd(0x72, 20, 4); or SerLCD lcd(0x72, 16, 2);

so this would be great to initialize the display directly with the main settings.

nseidle commented 4 years ago

I don't fully understand what you are suggesting, The display width and lines are set at the factory (SparkFun) by the firmware that runs on the actual display, not by this library.

Passing the address in the constructor is fine, but we almost always pass it in the begin function along side the Wire port so I won't be breaking that standard on this library.

hasenradball commented 4 years ago

Hi, ok that sounds fine I didn‘t catch that the cols and rows are set by the firmware.

Cool so my issue is obsolete 😀