Closed nseidle closed 3 years ago
Please don't merge until we get the library version rolled to 1.8.7 (separate PR - is there an easier way to get that in place?)
I normally just update everything in the release_candidate branch, including updating library.properties (as you've just done), then merge into master and then issue a new release of master. I don't think there's an easier way of doing it? I think you can safely remove the auto-review-request on the release-candidate branch? Assuming there is one? If these are all manually-requested reviews then that's perfectly fine! But having a mandatory review in place on master seems sensible, so long as it doesn't slow us down too much... I think I've checked all of your updates in the individual PR's but I'll give this one another look through just in case. Probably won't be until tomorrow though. It's dinner time over here! All the best, Paul
Good point. Restrictions removed from release-candidate so we can be more flexible.
No rush. Enjoy!
I think we're closer to merge. I'm happy to leave this PR open until issue 131 is resolved, or we can merge without it. Up to you Paul.
I think we're ready? I've just updated the example as Morten suggested. It's a lot better now.
This PR: