search

sparkfun / SparkFun_Ublox_Arduino_Library

Library to control UBX binary protocol and NMEA over I2C on Ublox GPS modules
Other
144 stars 85 forks source link

NAV-PVT velocity parameters parsed. #146

Closed balamuruganky closed 4 years ago

balamuruganky commented 4 years ago

Please consider to merge this request. NAV-PVT velocity parameters are parsed.

nseidle commented 4 years ago

Thank you! Looks pretty good. Please consider adding the new functions to the keyword.txt. Also, we'd love to see the new features demo'd in an example. These functions may fit best into a pre-existing example so please check.

balamuruganky commented 4 years ago

@nseidle : Thanks for your comments! I will add new functions in keywords.txt and write demo for newly added functions.

PaulZC commented 4 years ago

Hi @balamuruganky , You perhaps don't need to create a whole new example. You could add the accuracy estimates to this example: https://github.com/sparkfun/SparkFun_Ublox_Arduino_Library/blob/master/examples/Example13_PVT/Example1_AutoPVT/Example1_AutoPVT.ino Best wishes, Paul

PaulZC commented 4 years ago

Hi @balamuruganky , In keywords.txt, can you please use a TAB character (not a space) to separate the function from the KEYWORD2? Thanks! Paul

balamuruganky commented 4 years ago

@PaulZC : Sure. I will change accordingly.

balamuruganky commented 4 years ago

@nseidle, @PaulZC : Please review the changes and let me know, if you have any comments. Thanks much for your time.

PaulZC commented 4 years ago

Thank you @balamuruganky , I'm merging this into the release_candidate branch. We will test it and then hopefully merge into the master branch in a few days. Very best wishes, Paul