search

sparkfun / SparkFun_Ublox_Arduino_Library

Library to control UBX binary protocol and NMEA over I2C on Ublox GPS modules
Other
144 stars 84 forks source link

Update library helper links and correct all instances of "Ublox" #168

Closed adamgarbo closed 3 years ago

adamgarbo commented 3 years ago

Hi @PaulZC,

This PR for the v2.0 candidate includes a couple of minor changes:

1) I've replaced all instances of the //http://librarymanager/All#SparkFun_Ublox_GPS helper link with //http://librarymanager/All#SparkFun_u-blox_GPS

2) As part of our constant efforts to please the OCD gods (@nseidle may appreciate this), I've attempted to replace all instances of "Ublox" with "u-blox" contained in comments and/or print commands for the entire library.

I also manually reviewed all the changes to ensure I hadn't accidentally changed any instances of "Ublox" that were actually operational code.

Cheers, Adam

nseidle commented 3 years ago

Thank you for helping fix my Ublox correction quest! I get upset when people spell SparkFun Sparkfun, so I wanted to give the same respect to u-blox. This helps.

I want to shift SparkFun towards proper GNSS terminology so Adam, if I may ask you to, please change to 

//http://librarymanager/All#SparkFun_u-blox_GNSS
adamgarbo commented 3 years ago

@nseidle I was thinking the exact same thing as I was making the changes, but I wasn't sure if changing all instances of "GPS" to "GNSS" was a rock we wanted to turn over. I agree that as a community, we should endeavour to use proper terminology!

PaulZC commented 3 years ago

This is great Adam (@adamgarbo ) - sincere thanks! If you have time, can you target the master branch with the same changes? Thanks again, Paul