search

sparkfun / SparkFun_Ublox_Arduino_Library

Library to control UBX binary protocol and NMEA over I2C on Ublox GPS modules
Other
144 stars 84 forks source link

Linux platform #171

Closed balamuruganky closed 3 years ago

balamuruganky commented 3 years ago

@nseidle @PaulZC : Linux library porting is done. Serial port communication tested. i2c yet to be tested. Thanks.

PaulZC commented 3 years ago

Nice work @balamuruganky - thank you! This is a big addition to the library and we will need to test it first before we merge it. Can you please tell me what hardware you have tested this on? Also, can you please target your PR at the release_candidate branch - instead of master? (Please see this link) Thanks! Best wishes, Paul

balamuruganky commented 3 years ago

@PaulZC : I have tested in Ubuntu 18.04 LTS intel processor. Sure, it will do same for any ARM board linux too.

PaulZC commented 3 years ago

Thanks - but which board are you using? (So I can try compiling it for the same board)

balamuruganky commented 3 years ago

@PaulZC : To be honest, I didn't get chance to test in any ARM board. But, I am fairly confident that any ARM board linux should behave same as Ubuntu. However, I will test in Raspberry Pi 4 and let you know the result.

I have branched out from master to commit this code. Do you want me to merge with my github, 'release_candidate' branch?

balamuruganky commented 3 years ago

image

@PaulZC : I have tested in Raspberry Pi 4 Raspian OS. Screen shot attached. Thanks.

PaulZC commented 3 years ago

Thanks @balamuruganky - this is great stuff! I will have a chat to Nathan (@nseidle) about whether Linux support should be included as part of the Arduino library. We have a separate Python module which can run on Raspberry Pi, and I'm wondering if Linux should be a separate fork too. Things like Common.h and Utils.cpp really are not a natural fit in an Arduino library and may confuse less-experienced users. We'll chat about it and come back to you. But, either way, this is great stuff. Thank you again for taking the time to write it. All the best, Paul

balamuruganky commented 3 years ago

@PaulZC @nseidle : I completely agree that Linux code should not be included in Arduino release. That is the reason why separate branch is created. So whoever want C library for Ublox can switch to linux_platform branch, compile and make binary. Separate Linux library release can be done, if you both agreed. Have to test i2c. Need to order qwicc for Raspberry Pi. Shipping cost is half of product cost. Planning make combined order with other items as per my need. But, eventually will do i2c test. Thanks.

balamuruganky commented 3 years ago

@PaulZC @nseidle : Please share your thought on merging this PR. I understand that, this library is meant for Arduino. If you hesitate to merge with this code base as branch, I would suggest to maintain as separate repo. Thanks.

PaulZC commented 3 years ago

Hi @balamuruganky , Thank you again for working on this - it really is excellent. We have discussed this and we would like you to please maintain this as a separate repo. It does not need to be kept as a fork of the SparkFun library, but please mention in your README that it includes SparkFun's code, maintain attribution, and distribute under the same MIT license. We will be very happy to include a link to your repo from the SparkFun library repo. Please just let us know the URL. Thanks again for writing this. Very best wishes, Paul & Nathan

balamuruganky commented 3 years ago

@PaulZC : https://github.com/balamuruganky/Ublox_Linux_Library is the URL. Thanks.

PaulZC commented 3 years ago

@balamuruganky : I've added a link in the README in the release_candidate branch. We'll merge this into master in a few days - we have some other changes to add at the same time. Thanks again, Paul