search

sparkfun / SparkFun_VL53L1X_Arduino_Library

A library for the laser based VL53L1X Time Of Flight distance sensor capable of detecting a target 4m away!
MIT License
88 stars 50 forks source link

SFEVL53L1X::setROI sets wrong Y value #20

Closed matthias-mueller closed 5 years ago

matthias-mueller commented 5 years ago

Looks like a typo in the C code: https://github.com/sparkfun/SparkFun_VL53L1X_Arduino_Library/blob/1773c55cb9fe2427d5f6ceef2aaf080b380fc88f/src/SparkFun_VL53L1X.cpp#L273

It probably should be:

_device->VL53L1X_SetROI(x, y);
AndyEngland521 commented 5 years ago

Good catch, fixed with a separate pull request