search

sparkfun / SparkFun_VL53L1X_Arduino_Library

A library for the laser based VL53L1X Time Of Flight distance sensor capable of detecting a target 4m away!
MIT License
88 stars 50 forks source link

Default argument after previous specification in header #22

Closed matthias-mueller closed 5 years ago

matthias-mueller commented 5 years ago

https://github.com/sparkfun/SparkFun_VL53L1X_Arduino_Library/blob/1773c55cb9fe2427d5f6ceef2aaf080b380fc88f/src/SparkFun_VL53L1X.cpp#L6

The first argument should not have a default value (that has been already declared in header file). Fix:

SFEVL53L1X::SFEVL53L1X(TwoWire &i2cPort, int shutdownPin, int interruptPin)
AndyEngland521 commented 5 years ago

Good catch, fixed and pushed, check out v1.1.1