search

sparkfun / The_Flying_Jalapeno

One testbed to rule them all
1 stars 2 forks source link

PWR_CTRL naming convention #3

Closed ericorosel closed 7 years ago

ericorosel commented 7 years ago

Just a subjective thought here, but it would make the symbol more intuitive if we changed the names of pins 48 and 49.

Currently the two pins are named "48/PWR_CTRL1" and "49/PWR_CTRL2", I think it would be better to keep the naming convention that is consistent with the rest of the design. Thus naming them "48/PWR_CTRL_V1" and "49/PWR_CTRL_V2".

This is just a thought, as it stands the symbol isn't hard to interpret.

lewispg228 commented 7 years ago

Good catch. I like to keep things consistent. Fixed.

https://github.com/sparkfun/The_Flying_Jalapeno/commit/363d3e9350d92fd296667a5587c2d09a342b41f6

Note, I also changed this in the symbol in our SFE_Testing_Eagle_Library. Please be sure to sync that up.

image

https://github.com/sparkfun/SFE_Testing_Eagle_Library/