sparkfun / mbed-os-ambiq-apollo3

Arm Mbed OS is a platform operating system designed for the internet of things
https://mbed.com
Other
18 stars 14 forks source link

Ambiq apollo3 serial fix #31

Closed Wenn0101 closed 4 years ago

Wenn0101 commented 4 years ago

Major changes:

-made certain parts of the init only happen on the first init -comment out (is this the best option) part of ambiq hal that "sets up buffer" and disables interrupts if we arent using hal buffer -change hal to use AM_HAL_UART_FIFO_DISABLE because i couldn't find a threshold that would allow the interrupt to fire on each byte otherwise -serial_irq_set fixed to enable and disable individual interrupts -remove fluff, TODO's, and temp code.

outstanding questions -add FC or remove TODO's?

oclyke commented 4 years ago

@Wenn0101 just requested some changes mostly b/c I had questions. The only actual changes would be style nits and possibly another way of configuring the HAL to do what we need. Otherwise looks real good