search

sparkle-project / Sparkle

A software update framework for macOS
https://sparkle-project.org
Other
7.37k stars 1.05k forks source link

Avoid using set-output in GitHub Actions #2399

Open zorgiepoo opened 1 year ago

zorgiepoo commented 1 year ago

Fixes #2354

Misc Checklist

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

Testing this in CI and seeing if an analyzer warning gets triggered.

Sparkle-Bot commented 1 year ago

Sparkle-Bot commented 1 year ago 

        NSMutableArray *arguments = [@[@"attach", _archivePath, @"-mountpoint", mountPoint, /*@"-noverify",*/ @"-nobrowse", @"-noautoopen"] mutableCopy];
                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
note: Building targets in dependency order
note: Target dependency graph (9 targets)
    Target 'Sparkle' in project 'Sparkle'
        ➜ Explicit dependency on target 'SparkleDownloader' in project 'Sparkle'
        ➜ Explicit dependency on target 'SparkleInstallerConnection' in project 'Sparkle'
        ➜ Explicit dependency on target 'SparkleInstallerLauncher' in project 'Sparkle'
        ➜ Explicit dependency on target 'SparkleInstallerStatus' in project 'Sparkle'
        ➜ Explicit dependency on target 'Autoupdate' in project 'Sparkle'
        ➜ Explicit dependency on target 'Installer Progress' in project 'Sparkle'
    Target 'Installer Progress' in project 'Sparkle' (no dependencies)
    Target 'Autoupdate' in project 'Sparkle'
        ➜ Explicit dependency on target 'bsdiff' in project 'Sparkle'
        ➜ Explicit dependency on target 'ed25519' in project 'Sparkle'
    Target 'ed25519' in project 'Sparkle' (no dependencies)
    Target 'bsdiff' in project 'Sparkle' (no dependencies)
    Target 'SparkleInstallerStatus' in project 'Sparkle' (no dependencies)
    Target 'SparkleInstallerLauncher' in project 'Sparkle' (no dependencies)
    Target 'SparkleInstallerConnection' in project 'Sparkle' (no dependencies)
    Target 'SparkleDownloader' in project 'Sparkle' (no dependencies)
note: Run script build phase 'Strip Framework' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle')
note: Run script build phase 'Run Script: Set Git Version Info' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle')
note: Run script build phase 'Run Script: Link Tools' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle') ```
Sparkle-Bot commented 1 year ago

$(cat anaylze_output.txt)

Sparkle-Bot commented 1 year ago 

        NSMutableArray *arguments =   [@[@"attach", _archivePath, @"-mountpoint", mountPoint, /*@"-noverify",*/ @"-nobrowse", @"-noautoopen"] mutableCopy];
                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
note: Building targets in dependency order
note: Target dependency graph (9 targets)
    Target 'Sparkle' in project 'Sparkle'
        ➜ Explicit dependency on target 'SparkleDownloader' in project 'Sparkle'
        ➜ Explicit dependency on target 'SparkleInstallerConnection' in project 'Sparkle'
        ➜ Explicit dependency on target 'SparkleInstallerLauncher' in project 'Sparkle'
        ➜ Explicit dependency on target 'SparkleInstallerStatus' in project 'Sparkle'
        ➜ Explicit dependency on target 'Autoupdate' in project 'Sparkle'
        ➜ Explicit dependency on target 'Installer Progress' in project 'Sparkle'
    Target 'Installer Progress' in project 'Sparkle' (no dependencies)
    Target 'Autoupdate' in project 'Sparkle'
        ➜ Explicit dependency on target 'bsdiff' in project 'Sparkle'
        ➜ Explicit dependency on target 'ed25519' in project 'Sparkle'
    Target 'ed25519' in project 'Sparkle' (no dependencies)
    Target 'bsdiff' in project 'Sparkle' (no dependencies)
    Target 'SparkleInstallerStatus' in project 'Sparkle' (no dependencies)
    Target 'SparkleInstallerLauncher' in project 'Sparkle' (no dependencies)
    Target 'SparkleInstallerConnection' in project 'Sparkle' (no dependencies)
    Target 'SparkleDownloader' in project 'Sparkle' (no dependencies)
note: Run script build phase 'Strip Framework' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle')
note: Run script build phase 'Run Script: Set Git Version Info' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle')
note: Run script build phase 'Run Script: Link Tools' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle') ```
Sparkle-Bot commented 1 year ago

/Users/runner/work/Sparkle/Sparkle/Autoupdate/SUDiskImageUnarchiver.m:83:41: warning: Array element cannot be nil [osx.cocoa.NilArg] NSMutableArray *arguments = [@[@"attach", _archivePath, @"-mountpoint", mountPoint, /*@"-noverify",*/ @"-nobrowse", @"-noautoopen"] mutableCopy]; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. note: Building targets in dependency order note: Target dependency graph (9 targets) Target 'Sparkle' in project 'Sparkle' ➜ Explicit dependency on target 'SparkleDownloader' in project 'Sparkle' ➜ Explicit dependency on target 'SparkleInstallerConnection' in project 'Sparkle' ➜ Explicit dependency on target 'SparkleInstallerLauncher' in project 'Sparkle' ➜ Explicit dependency on target 'SparkleInstallerStatus' in project 'Sparkle' ➜ Explicit dependency on target 'Autoupdate' in project 'Sparkle' ➜ Explicit dependency on target 'Installer Progress' in project 'Sparkle' Target 'Installer Progress' in project 'Sparkle' (no dependencies) Target 'Autoupdate' in project 'Sparkle' ➜ Explicit dependency on target 'bsdiff' in project 'Sparkle' ➜ Explicit dependency on target 'ed25519' in project 'Sparkle' Target 'ed25519' in project 'Sparkle' (no dependencies) Target 'bsdiff' in project 'Sparkle' (no dependencies) Target 'SparkleInstallerStatus' in project 'Sparkle' (no dependencies) Target 'SparkleInstallerLauncher' in project 'Sparkle' (no dependencies) Target 'SparkleInstallerConnection' in project 'Sparkle' (no dependencies) Target 'SparkleDownloader' in project 'Sparkle' (no dependencies) note: Run script build phase 'Strip Framework' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle') note: Run script build phase 'Run Script: Set Git Version Info' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle') note: Run script build phase 'Run Script: Link Tools' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle')